moved tests to be inside package. #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so they can be run from an install, and won't be installed as a separate pacakge called "tests" Also added a standard .gitignore file for Python.
…sion in the package __init__.py .
Closed
|
turns out that method doesn't include the test data files -- that could be added to the setup.py, but maybe easier to keep tests outside of package. So closing this, stay tuned for another PR |
Closed
36 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so they can be run from an install, and won't be installed as a
separate package called "tests"
Also added a standard .gitignore file for Python.
NOTE: there are still test failures due to missing data files, but this is a start.
Another option is to keep the tests separate, but remove the init.py, so that setuptools.find_packages won't find it and install it as a a top-level package (which is what is happening now).